Skip to content

chore: remove resolution-mode=highest in template .npmrc#10635

Merged
benmccann merged 3 commits intosveltejs:masterfrom
oekazuma:rm-resolution-mode-highest
Sep 18, 2023
Merged

chore: remove resolution-mode=highest in template .npmrc#10635
benmccann merged 3 commits intosveltejs:masterfrom
oekazuma:rm-resolution-mode-highest

Conversation

@oekazuma
Copy link
Contributor

@oekazuma oekazuma commented Aug 27, 2023

In pnpm v8.7.0, the resolution-mode is now set to highest by default.
Thus, I believe it is possible to remove the settings previously made in this PR

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b45a176

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

dummdidumm commented Aug 27, 2023

Agree, but let's wait a few more weeks to ensure more people have upgraded to that version

@ghostdevv
Copy link
Member

ghostdevv commented Aug 27, 2023

Deployment targets like Cloudflare are still installing 8.2 even though there have been important bug fixes in versions like 8.6 :/ Maybe it's worth waiting a while longer or nagging everyone a bit more to stay up to date (I have tried with Cloudflare specifically)

@benmccann
Copy link
Member

benmccann commented Aug 28, 2023

I think it shouldn't matter what version is on cloudflare because the lockfile will be used. But people will need to update locally to generate the correct lockfile

benmccann
benmccann reviewed Sep 18, 2023
View reviewed changes
@benmccann benmccann changed the title feat: remove resolution-mode=highest in template .npmrc chore: remove resolution-mode=highest in template .npmrc Sep 18, 2023
@benmccann benmccann merged commit 671d3e0 into sveltejs:master Sep 18, 2023
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Merged
@oekazuma oekazuma deleted the rm-resolution-mode-highest branch September 18, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oekazuma @dummdidumm @ghostdevv @benmccann